Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/cassandra] change backup image, add parallel to values #9193

Closed
wants to merge 3 commits into from
Closed

[incubator/cassandra] change backup image, add parallel to values #9193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7038732
[incubator/cassandra] change backup image, add parallel to values
maorfr Nov 12, 2018
39cf345
[incubator/cassandra] bump chart version for backup
maorfr Nov 12, 2018
2e0fa59
[incubator/cassandra] update backup configuration (lint)
maorfr Nov 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion incubator/cassandra/Chart.yaml
View file
Open in desktop
@@ -1,5 +1,5 @@
name: cassandra
version: 0.9.1
version: 0.9.2
appVersion: 3.11.3
description: Apache Cassandra is a free and open-source distributed database management
system designed to handle large amounts of data across many commodity servers, providing
Expand Down
3 changes: 2 additions & 1 deletion incubator/cassandra/README.md
View file
Open in desktop
Expand Up @@ -125,11 +125,12 @@ The following table lists the configurable parameters of the Cassandra chart and
| `backup.enabled` | Enable backup on chart installation | `false` |
| `backup.schedule` | Keyspaces to backup, each with cron time | |
| `backup.annotations` | Backup pod annotations | iam.amazonaws.com/role: `cain` |
| `backup.image.repo` | Backup image repository | `maorfr/cain` |
| `backup.image.repo` | Backup image repository | `nuvo/cain` |
| `backup.image.tag` | Backup image tag | `0.1.0` |
| `backup.env` | Backup environment variables | AWS_REGION: `us-east-1` |
| `backup.resources` | Backup CPU/Memory resource requests/limits | Memory: `1Gi`, CPU: `1` |
| `backup.destination` | Destination to store backup artifacts | `s3://bucket/cassandra` |
| `backup.parallel` | Copy n files in parallel | `1` |
| `exporter.enabled` | Enable Cassandra exporter | `false` |
| `exporter.image.repo` | Exporter image repository | `criteord/cassandra_exporter` |
| `exporter.image.tag` | Exporter image tag | `2.0.2` |
Expand Down
2 changes: 1 addition & 1 deletion incubator/cassandra/templates/backup/cronjob.yaml
View file
Open in desktop
Expand Up @@ -41,7 +41,7 @@ spec:
- --dst
- {{ $backup.destination }}
- --parallel
- "0"
- "{{ $backup.parallel }}"
{{- with $backup.env }}
env:
{{ toYaml . | indent 12 }}
Expand Down
8 changes: 6 additions & 2 deletions incubator/cassandra/values.yaml
View file
Open in desktop
Expand Up @@ -154,7 +154,7 @@ backup:
iam.amazonaws.com/role: cain

image:
repos: maorfr/cain
repos: nuvo/cain
tag: 0.1.0

# Add additional environment variables
Expand All @@ -174,9 +174,13 @@ backup:
# Destination to store the backup artifacts
# Currently only s3 is supported
# Additional support can added.
# Ref: https://github.com/maorfr/skbn
# Ref: https://github.com/nuvo/skbn
destination: s3://bucket/cassandra

# Copy n files in parallel
# 0 for full parallelism
parallel: 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to maintain default ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always feel that the values.yaml file should provide an easy interface to change things when you need, instead of digging in the templates...
when increasing parallelism - it increases resource usage, so I think it is better left for the user to decide.

What do you think?


## Cassandra exported configuration
## ref: https://github.com/criteo/cassandra_exporter
exporter:
Expand Down