Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus] Remove unnecessary reclaim policy #9471

Merged
merged 1 commit into from Nov 22, 2018
Merged

[stable/prometheus] Remove unnecessary reclaim policy #9471

merged 1 commit into from Nov 22, 2018

Conversation

yuanying
Copy link
Contributor

persistentVolumeReclaimPolicy is unnecessary for PVC, so let's
remove it.

Signed-off-by: OTSUKA, Yuanying yuanying@fraction.jp

What this PR does / why we need it:

persistentVolumeReclaimPolicy is unnecessary for PVC, so let's
remove it.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 22, 2018
@yuanying
[stable/prometheus] Remove unnecessary reclaim policy
f954608 
persistentVolumeReclaimPolicy is unnecessary for PVC, so let's
remove it.

Signed-off-by: OTSUKA, Yuanying <mototsuk@zlab.co.jp>
@yuanying yuanying force-pushed the remove-unnecessary-reclaim-policy branch from cd0ea72 to f954608 Compare November 22, 2018 05:44
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 22, 2018
@steven-sheehy
Copy link
Collaborator

@yuanying is right. Reclaim policy was just added three days ago in PR #9284. Not sure why that was approved, as there is no field "persistentVolumeReclaimPolicy" in a PersistentVolumeClaim.

@gianrubio
Copy link
Collaborator

/ok-to-test
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gianrubio, yuanying

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 22, 2018
@k8s-ci-robot k8s-ci-robot merged commit 6af6c5a into helm:master Nov 22, 2018
@hairyhenderson
Copy link
Contributor

I issued #9284, and clearly I misunderstood what I was doing 😉 - I had confused PersistentVolumes and PersistentVolumeClaims. We ran into an issue where the PV was deleted after the PVC was accidentally deleted, losing us all of our Prometheus data.

I thought that adding a persistentVolumeReclaimPolicy to the PVC would fix it, but obviously not!

davidkarlsen pushed a commit to davidkarlsen/charts that referenced this pull request Dec 2, 2018
@yuanying @davidkarlsen
[stable/prometheus] Remove unnecessary reclaim policy (helm#9471)
af5bbcd 
persistentVolumeReclaimPolicy is unnecessary for PVC, so let's
remove it.

Signed-off-by: OTSUKA, Yuanying <mototsuk@zlab.co.jp>
yuchaoran2011 pushed a commit to yuchaoran2011/charts that referenced this pull request Dec 11, 2018
@yuanying @yuchaoran2011
[stable/prometheus] Remove unnecessary reclaim policy (helm#9471)
a157743 
persistentVolumeReclaimPolicy is unnecessary for PVC, so let's
remove it.

Signed-off-by: OTSUKA, Yuanying <mototsuk@zlab.co.jp>
Signed-off-by: Chaoran Yu <yuchaoran2011@gmail.com>
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
@yuanying @wgiddens
[stable/prometheus] Remove unnecessary reclaim policy (helm#9471)
2c1a503 
persistentVolumeReclaimPolicy is unnecessary for PVC, so let's
remove it.

Signed-off-by: OTSUKA, Yuanying <mototsuk@zlab.co.jp>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gianrubio gianrubio Awaiting requested review from gianrubio

@mgoodness mgoodness Awaiting requested review from mgoodness

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yuanying @steven-sheehy @gianrubio @k8s-ci-robot @hairyhenderson @helm-bot