Skip to content

Commit

Permalink
[stable/prometheus] Remove unnecessary reclaim policy (helm#9471)
Browse files Browse the repository at this point in the history
persistentVolumeReclaimPolicy is unnecessary for PVC, so let's
remove it.

Signed-off-by: OTSUKA, Yuanying <mototsuk@zlab.co.jp>
Signed-off-by: Chaoran Yu <yuchaoran2011@gmail.com>
  • Loading branch information
yuanying authored and yuchaoran2011 committed Dec 11, 2018
1 parent e95dcb4 commit a157743
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 9 deletions.
2 changes: 1 addition & 1 deletion stable/prometheus/Chart.yaml
@@ -1,5 +1,5 @@
name: prometheus
version: 7.4.4
version: 7.4.5
appVersion: 2.5.0
description: Prometheus is a monitoring system and time series database.
home: https://prometheus.io/
Expand Down
1 change: 0 additions & 1 deletion stable/prometheus/README.md
Expand Up @@ -246,7 +246,6 @@ Parameter | Description | Default
`server.persistentVolume.annotations` | Prometheus server data Persistent Volume annotations | `{}`
`server.persistentVolume.existingClaim` | Prometheus server data Persistent Volume existing claim name | `""`
`server.persistentVolume.mountPath` | Prometheus server data Persistent Volume mount root path | `/data`
`server.persistentVolume.reclaimPolicy` | Prometheus server data Persistent Volume reclaim policy | `Retain`
`server.persistentVolume.size` | Prometheus server data Persistent Volume size | `8Gi`
`server.persistentVolume.storageClass` | Prometheus server data Persistent Volume Storage Class | `unset`
`server.persistentVolume.subPath` | Subdirectory of Prometheus server data Persistent Volume to mount | `""`
Expand Down
1 change: 0 additions & 1 deletion stable/prometheus/templates/server-pvc.yaml
Expand Up @@ -24,7 +24,6 @@ spec:
storageClassName: "{{ .Values.server.persistentVolume.storageClass }}"
{{- end }}
{{- end }}
persistentVolumeReclaimPolicy: {{ .Values.server.persistentVolume.reclaimPolicy | quote }}
resources:
requests:
storage: "{{ .Values.server.persistentVolume.size }}"
Expand Down
6 changes: 0 additions & 6 deletions stable/prometheus/values.yaml
Expand Up @@ -651,12 +651,6 @@ server:
##
subPath: ""

## reclaimPolicy for the persistent volume.
## See https://kubernetes.io/docs/tasks/administer-cluster/change-pv-reclaim-policy/
## Can be Retain, Recycle, or Delete
##
reclaimPolicy: Retain

## Annotations to be added to Prometheus server pods
##
podAnnotations: {}
Expand Down

0 comments on commit a157743

Please sign in to comment.