Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/drone]: NOTES.txt update #9815

Merged
merged 2 commits into from Dec 7, 2018
Merged

[stable/drone]: NOTES.txt update #9815

merged 2 commits into from Dec 7, 2018

Conversation

philoserf
Copy link
Contributor

Using existing NOTES.txt resulted with:
zsh: no matches found: server.envSecrets.drone-server-secrets[0]=DRONE_GITHUB_SECRET
fixed by adding qoutes around
--set 'server.envSecrets.drone-server-secrets[0]=DRONE_GITHUB_SECRET'

trivial, docs, drone chart

Signed-off-by: Mark Ayers mark@philoserf.com

Using existing `NOTES.txt` resulted with:
`zsh: no matches found: server.envSecrets.drone-server-secrets[0]=DRONE_GITHUB_SECRET`
fixed by adding qoutes around
`--set 'server.envSecrets.drone-server-secrets[0]=DRONE_GITHUB_SECRET'`

trivial, docs, drone chart

Signed-off-by: Mark Ayers <mark@philoserf.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2018
@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). labels Dec 7, 2018
Signed-off-by: Mark Ayers <mark@philoserf.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 7, 2018
@philoserf
Copy link
Contributor Author

NOTE: The following is always printed at is inaccurate after the settings are added. ERROR:... block should be reworded to indicate the intention of the warning.

NOTES:
##############################################################################
####        ERROR: You did not set a valid version control provider       ####
##############################################################################

@davidkarlsen
Copy link
Member

/ok-to-test
/assign
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. labels Dec 7, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, philoserf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2018
@k8s-ci-robot k8s-ci-robot merged commit 490a7d1 into helm:master Dec 7, 2018
@philoserf philoserf deleted the add-quoting-to-drone-notes-txt branch December 8, 2018 01:38
@philoserf philoserf changed the title fix(docs): drone NOTES.txt update [stable/drone]: NOTES.txt update Dec 10, 2018
yuchaoran2011 pushed a commit to yuchaoran2011/charts that referenced this pull request Dec 11, 2018
* fix(docs): drone NOTES.txt update

Using existing `NOTES.txt` resulted with:
`zsh: no matches found: server.envSecrets.drone-server-secrets[0]=DRONE_GITHUB_SECRET`
fixed by adding qoutes around
`--set 'server.envSecrets.drone-server-secrets[0]=DRONE_GITHUB_SECRET'`

trivial, docs, drone chart

Signed-off-by: Mark Ayers <mark@philoserf.com>

* bump version

Signed-off-by: Mark Ayers <mark@philoserf.com>
Signed-off-by: Chaoran Yu <yuchaoran2011@gmail.com>
coreypobrien pushed a commit to FairwindsOps/helm-charts that referenced this pull request Dec 31, 2018
* fix(docs): drone NOTES.txt update

Using existing `NOTES.txt` resulted with:
`zsh: no matches found: server.envSecrets.drone-server-secrets[0]=DRONE_GITHUB_SECRET`
fixed by adding qoutes around
`--set 'server.envSecrets.drone-server-secrets[0]=DRONE_GITHUB_SECRET'`

trivial, docs, drone chart

Signed-off-by: Mark Ayers <mark@philoserf.com>

* bump version

Signed-off-by: Mark Ayers <mark@philoserf.com>
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
* fix(docs): drone NOTES.txt update

Using existing `NOTES.txt` resulted with:
`zsh: no matches found: server.envSecrets.drone-server-secrets[0]=DRONE_GITHUB_SECRET`
fixed by adding qoutes around
`--set 'server.envSecrets.drone-server-secrets[0]=DRONE_GITHUB_SECRET'`

trivial, docs, drone chart

Signed-off-by: Mark Ayers <mark@philoserf.com>

* bump version

Signed-off-by: Mark Ayers <mark@philoserf.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants