Skip to content

Commit

Permalink
Add a note that git is required to make use of git based deps
Browse files Browse the repository at this point in the history
Signed-off-by: Dominykas Blyžė <hello@dominykas.com>
  • Loading branch information
dominykas committed Dec 15, 2023
1 parent 7b4771b commit 4fc29f1
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion hips/hip-00NN.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
hip: "00NN"
title: "Support Git protocol for installing chart dependencies"
authors: [ "Jeff Valore (@rally25rs)", "yxxhero <aiopsclub@163.com>", "Dominykas Blyžė <hello@dominykas.com>" ]
authors: [ "Jeff Valore (@rally25rs)", "yxxhero <aiopsclub@163.com>", "Dominykas Blyžė <hello@dominykas.com>", "George Jenkins <gvjenkins@gmail.com>" ]
created: "2021-10-05"
type: "feature"
status: "draft"
Expand Down Expand Up @@ -59,6 +59,7 @@ When Helm is installing a dependency from git, it should:

- create a temporary directory
- clone the repo at the specified branch/tag into the temp dir
- Helm will require a working git installation to invoke (via subprocess) in order for Helm to utilize chart's git dependencies. Helm will throw an error if git is not installed or misconfigured (e.g. credentials are not set up for private repositories).
- for performance reasons, a shallow clone of just the latest commit of a specific branch should be performed (i.e. `git clone --depth 1 --branch <commit-ish> --single-branch --no-tags <repo-url> <temp-dir>`)
- treat the cloned git repo similar to a `file:///path/to/temp/dir` style requirement; use `chart.LoadDir` to load that directory (which in turn applied the logic for filtering the files through `.helmignore`) and archives it to `charts/`
- delete the temp dir
Expand Down

0 comments on commit 4fc29f1

Please sign in to comment.