Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIP for git based dependencies #321

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

HIP for git based dependencies #321

wants to merge 11 commits into from

Commits on Nov 22, 2023

  1. add git support hip 

    Signed-off-by: yxxhero <aiopsclub@163.com>

fix typo

Signed-off-by: yxxhero <aiopsclub@163.com>

Update hip-0015.md

Signed-off-by: yxxhero <aiopsclub@163.com>

mv hip 0015 to 0016

Signed-off-by: yxxhero <aiopsclub@163.com>
Signed-off-by: Dominykas Blyžė <hello@dominykas.com>
    @yxxhero @dominykas
    yxxhero authored and dominykas committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    26b5b57 View commit details
    Browse the repository at this point in the history

  2. Update the HIP structure to follow the recommended template 

    Signed-off-by: Dominykas Blyžė <hello@dominykas.com>
    @dominykas
    dominykas committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    3b1a31c View commit details
    Browse the repository at this point in the history

  3. Add Jeff Valore to authors, as the previous HIP was based on their work 

    Signed-off-by: Dominykas Blyžė <hello@dominykas.com>
    @dominykas
    dominykas committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    7f72335 View commit details
    Browse the repository at this point in the history

  4. Fill out rationale, security implications, etc 

    Signed-off-by: Dominykas Blyžė <hello@dominykas.com>
    @dominykas
    dominykas committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    3d4984e View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Remove user/password in the repository URL format 

    While we may or may not explicitly forbid this format, it is probably a good idea to not officially document it, so as to avoid the proliferation bad practices and accidental leakage of secrets.

Signed-off-by: Dominykas Blyžė <hello@dominykas.com>
    @dominykas
    dominykas committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    888817f View commit details
    Browse the repository at this point in the history

  2. Reword <protocol> to explicitly say git[+<subprotocol>] 

    As the protocols are handled by git, it's probably better to define them as something that's supported by `git clone`.

Signed-off-by: Dominykas Blyžė <hello@dominykas.com>
    @dominykas
    dominykas committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    0f6cd2f View commit details
    Browse the repository at this point in the history

  3. Note on git clone perf 

    Signed-off-by: Dominykas Blyžė <hello@dominykas.com>
    @dominykas
    dominykas committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    7d89b46 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Forbid username/password in the git repository URL 

    Signed-off-by: Dominykas Blyžė <hello@dominykas.com>
    @dominykas
    dominykas committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    7b4771b View commit details
    Browse the repository at this point in the history

  2. Add a note that git is required to make use of git based deps 

    Signed-off-by: Dominykas Blyžė <hello@dominykas.com>
    @dominykas
    dominykas committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    4fc29f1 View commit details
    Browse the repository at this point in the history

  3. Note that helm lint should warn about git deps 

    Signed-off-by: Dominykas Blyžė <hello@dominykas.com>
    @dominykas
    dominykas committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    c16a922 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Document #subdirectory=<path-inside-the-repository> approach 

    Signed-off-by: Dominykas Blyžė <hello@dominykas.com>
    @dominykas
    dominykas committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    b61033b View commit details
    Browse the repository at this point in the history