Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate topic : 'chart tests' in Korean #850

Merged
merged 18 commits into from
Oct 5, 2020

Conversation

bluefriday
Copy link
Contributor

Signed-off-by: bluefriday bluefriday86@gmail.com
Translate topic : 'chart tests' in Korean

@bluefriday
Copy link
Contributor Author

@jmnote @jmyung @sunminjeon
리뷰 부탁드립니다.

@jmnote
Copy link
Contributor

jmnote commented Sep 22, 2020

Copy link
Contributor

@jmnote jmnote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다. 현재의 영어판과 약간 차이가 있습니다. 추가된 후 다시 review 하겠습니다.

content/ko/docs/topics/chart_tests.md Show resolved Hide resolved
content/ko/docs/topics/chart_tests.md Outdated Show resolved Hide resolved
content/ko/docs/topics/chart_tests.md Outdated Show resolved Hide resolved
content/ko/docs/topics/chart_tests.md Show resolved Hide resolved
@bluefriday
Copy link
Contributor Author

수고하셨습니다. 현재의 영어판과 약간 차이가 있습니다. 추가된 후 다시 review 하겠습니다.

변경된 부분을 추가하여 다시 번역하겠습니다 :D

@bluefriday
Copy link
Contributor Author

@jmnote 해당 내용 추가하였습니다.

Copy link
Contributor

@jmnote jmnote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.

content/ko/docs/topics/chart_tests.md Outdated Show resolved Hide resolved
content/ko/docs/topics/chart_tests.md Outdated Show resolved Hide resolved
content/ko/docs/topics/chart_tests.md Outdated Show resolved Hide resolved
content/ko/docs/topics/chart_tests.md Outdated Show resolved Hide resolved
content/ko/docs/topics/chart_tests.md Outdated Show resolved Hide resolved
content/ko/docs/topics/chart_tests.md Outdated Show resolved Hide resolved
content/ko/docs/topics/chart_tests.md Outdated Show resolved Hide resolved
content/ko/docs/topics/chart_tests.md Outdated Show resolved Hide resolved
@bluefriday
Copy link
Contributor Author

수고하셨습니다.

@jmnote 의견 주신 부분 반영하여 commit 하였습니다.

Copy link
Contributor

@jmnote jmnote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

띄어쓰기 1개 수정합니다.

content/ko/docs/topics/chart_tests.md Outdated Show resolved Hide resolved
content/ko/docs/topics/chart_tests.md Show resolved Hide resolved
content/ko/docs/topics/chart_tests.md Outdated Show resolved Hide resolved
content/ko/docs/topics/chart_tests.md Outdated Show resolved Hide resolved
content/ko/docs/topics/chart_tests.md Show resolved Hide resolved
@bluefriday
Copy link
Contributor Author

@jmnote @singlemocha 리뷰 감사드립니다. 의견 주신 내용에 따라 번역을 수정하였습니다.

bluefriday and others added 15 commits September 25, 2020 17:09
Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com>
Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com>
Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com>
Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com>
Signed-off-by: bluefriday <bluefriday86@gmail.com>
Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com>
Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com>
Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com>
Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com>
Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com>
Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com>
Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com>
Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com>
Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com>
Signed-off-by: bluefriday <bluefriday86@gmail.com>
Signed-off-by: bluefriday <bluefriday86@gmail.com>
Signed-off-by: bluefriday <bluefriday86@gmail.com>
Signed-off-by: bluefriday <bluefriday86@gmail.com>
@jmnote
Copy link
Contributor

jmnote commented Oct 5, 2020

lgtm

Copy link
Member

@bridgetkromhout bridgetkromhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bridgetkromhout bridgetkromhout merged commit 32f7da2 into helm:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants