Translate topic : v2 v3 migration #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmnote @jmyung @singlemocha |
Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
bluefriday
force-pushed
the
translate-ko-bluefriday-23
branch
from
09ecdd1
to
e8466dd
Compare
|
@jmnote 세세하게 리뷰해주셔서 감사합니다. |
Co-authored-by: Jmnote <opcore@gmail.com> Signed-off-by: bluefriday <bluefriday86@gmail.com>
bluefriday
force-pushed
the
translate-ko-bluefriday-23
branch
from
61babe0
to
94f9cce
Compare
|
@jmnote 말씀해주신 부분에 대하여 반영하였습니다. |
|
LGTM |
|
Thanks. I submitted a PR #881 with some clarifications for this doc - in particular, you might want to ensure your meaning is "one or more" not "one to many". So I'll merge this now, but please do submit any necessary changes. |
bridgetkromhout
approved these changes
Oct 7, 2020
@bridgetkromhout I will open new issue soon. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: bluefriday bluefriday86@gmail.com
Translate topic : v2 v3 migration