Skip to content

Commit

Permalink
fix(tiller): fix nil pointers in error messages
Browse files Browse the repository at this point in the history
There were a few places where error messages were accessing properties
of objects that were nil because of the error.

Closes #1374
  • Loading branch information
technosophos committed Oct 17, 2016
1 parent d744a3d commit a1f5955
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/storage/driver/cfgmaps.go
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ func (cfgmaps *ConfigMaps) List(filter func(*rspb.Release) bool) ([]*rspb.Releas
for _, item := range list.Items {
rls, err := decodeRelease(item.Data["release"])
if err != nil {
logerrf(err, "list: failed to decode release: %s", rls)
logerrf(err, "list: failed to decode release: %v", item)
continue
}
if filter(rls) {
Expand Down Expand Up @@ -201,7 +201,7 @@ func (cfgmaps *ConfigMaps) Delete(key string) (rls *rspb.Release, err error) {
return nil, ErrReleaseNotFound
}

logerrf(err, "delete: failed to get release %q", rls.Name)
logerrf(err, "delete: failed to get release %q", key)
return nil, err
}
// delete the release
Expand Down

0 comments on commit a1f5955

Please sign in to comment.