Merge pull request #5236 from Lentil1016/migrate-sort-manifest

Refactor: migrate SortManifests and its test case to releaseutil
helm · Mar 19, 2019 · a8d73ff · a8d73ff
2 parents c45496b + 223148d
commit a8d73ff
Showing 1 changed file with 0 additions and 1 deletion.
diff --git a/pkg/action/install.go b/pkg/action/install.go
@@ -329,7 +329,6 @@ func (i *Install) renderResources(ch *chart.Chart, values chartutil.Values, vs c
 	// Sort hooks, manifests, and partials. Only hooks and manifests are returned,
 	// as partials are not used after renderer.Render. Empty manifests are also
 	// removed here.
-	// TODO: Can we migrate SortManifests out of pkg/tiller?
 	hooks, manifests, err := releaseutil.SortManifests(files, vs, releaseutil.InstallOrder)
 	if err != nil {
 		// By catching parse errors here, we can prevent bogus releases from going