New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: migrate SortManifests and its test case to releaseutil #5236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
label
Jan 30, 2019
lentil1016
force-pushed
the
migrate-sort-manifest
branch
from
January 30, 2019 13:55
1b2e455
to
28b4f34
Compare
helm-bot
added
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
and removed
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Jan 30, 2019
lentil1016
changed the title
Refactor: migrate SortManifests and its test case to releaseutil
[WIP]Refactor: migrate SortManifests and its test case to releaseutil
Jan 30, 2019
lentil1016
force-pushed
the
migrate-sort-manifest
branch
from
January 30, 2019 14:12
28b4f34
to
7ddda17
Compare
helm-bot
added
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Jan 30, 2019
lentil1016
force-pushed
the
migrate-sort-manifest
branch
from
January 30, 2019 15:22
7ddda17
to
b578ece
Compare
helm-bot
added
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Jan 30, 2019
lentil1016
force-pushed
the
migrate-sort-manifest
branch
from
January 30, 2019 15:28
b578ece
to
24ea517
Compare
helm-bot
added
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Jan 30, 2019
lentil1016
changed the title
[WIP]Refactor: migrate SortManifests and its test case to releaseutil
Refactor: migrate SortManifests and its test case to releaseutil
Jan 30, 2019
bacongobbler
added
the
v3.x
Issues and Pull Requests related to the major version v3
label
Jan 30, 2019
lentil1016
force-pushed
the
migrate-sort-manifest
branch
from
February 1, 2019 03:15
24ea517
to
533cb3c
Compare
helm-bot
added
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Feb 1, 2019
adamreese
added
the
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
label
Mar 18, 2019
lentil1016
force-pushed
the
migrate-sort-manifest
branch
from
March 19, 2019 05:51
533cb3c
to
5c27e58
Compare
helm-bot
added
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
and removed
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
labels
Mar 19, 2019
lentil1016
force-pushed
the
migrate-sort-manifest
branch
from
March 19, 2019 05:56
5c27e58
to
c45496b
Compare
helm-bot
added
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
and removed
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Mar 19, 2019
helm-bot
added
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
and removed
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Mar 19, 2019
@adamreese OK, This PR was trying to refactor |
Signed-off-by: Sunyk <lentil1016@gmail.com>
lentil1016
force-pushed
the
migrate-sort-manifest
branch
from
March 19, 2019 06:04
2561aa7
to
223148d
Compare
helm-bot
added
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
and removed
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Mar 19, 2019
bacongobbler
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs-rebase
Indicates a PR cannot be merged because it has merge conflicts with HEAD.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
v3.x
Issues and Pull Requests related to the major version v3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Hi. I'm currently working on a new feature on branch
dev-v3
and I found a TODO in my way to implement this feature.helm/pkg/action/install.go
Lines 293 to 299 in 86d8596
sortManifests
and its test case in pkg/tiller into pkg/releaseutilManifest
,manifestFile
,result
in pkg/tiller into pkg/releaseutilSortByKind
inreleaseutil
tiller
package.Special notes for your reviewer:
If applicable: