Skip to content

Commit

Permalink
Basic auth credentials from repo not used in install/upgrade/fetch co…
Browse files Browse the repository at this point in the history
…mmands #3858
  • Loading branch information
eyalbe4 committed Apr 11, 2018
1 parent f0e7da6 commit fa62c47
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/downloader/chart_downloader.go
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,6 @@ func (c *ChartDownloader) ResolveChartVersionAndGetRepo(ref, version string) (*u
if err != nil {
return u, nil, nil, err
}
g.SetCredentials(c.getRepoCredentials(nil))

if u.IsAbs() && len(u.Host) > 0 && len(u.Path) > 0 {
// In this case, we have to find the parent repo that contains this chart
Expand Down Expand Up @@ -203,6 +202,7 @@ func (c *ChartDownloader) ResolveChartVersionAndGetRepo(ref, version string) (*u
repoName := p[0]
chartName := p[1]
rc, err := pickChartRepositoryConfigByName(repoName, rf.Repositories)

if err != nil {
return u, nil, nil, err
}
Expand All @@ -211,6 +211,7 @@ func (c *ChartDownloader) ResolveChartVersionAndGetRepo(ref, version string) (*u
if err != nil {
return u, nil, nil, err
}
g.SetCredentials(c.getRepoCredentials(r))

// Next, we need to load the index, and actually look up the chart.
i, err := repo.LoadIndexFile(c.HelmHome.CacheIndex(r.Config.Name))
Expand Down

0 comments on commit fa62c47

Please sign in to comment.