Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] helm package should have --version flag #1480

Closed
jchauncey opened this issue Oct 31, 2016 · 3 comments
Closed

[Feature Request] helm package should have --version flag #1480

jchauncey opened this issue Oct 31, 2016 · 3 comments
Assignees
Milestone

Comments

@jchauncey
Copy link

We all know that the version of a package is derived from the Chart.yaml. However, if you are wanting to deliver a new chart artifact for each commit pushed to master changing that file is rather cumbersome (modifying a file in CI is dangerous and having to change that file for each commit seems inefficient).

Instead, it would be very useful to have a --version flag which would be part of the helm package command. This would allow us to override the value in Chart.yaml within a CI environment without mucking up the workspace.

@technosophos technosophos added this to the 2.1.0-Alpha.1 milestone Oct 31, 2016
@technosophos technosophos modified the milestones: 2.1.0-Alpha.1, 2.1.0 Nov 10, 2016
@technosophos technosophos modified the milestones: 2.2.0, 2.1.0 Dec 13, 2016
@technosophos technosophos self-assigned this Dec 15, 2016
@technosophos
Copy link
Member

@jchauncey Just to make sure I am reading this right, you'd want that change to be written to disk, too, right?

In other words, I would be able to do this:

$ grep version Chart.yaml
version: 1.2.3
$ helm package --version 2.3.4 .
$ grep version Chart.yaml
version: 2.3.4

Does that look correct?

@jchauncey
Copy link
Author

jchauncey commented Dec 15, 2016 via email

technosophos added a commit to technosophos/k8s-helm that referenced this issue Dec 17, 2016
This adds a `helm package --version=SEMVER` param that allows users to
set a version during a package operation.

Closes helm#1480
Closes helm#1699
technosophos added a commit to technosophos/k8s-helm that referenced this issue Dec 19, 2016
This adds a `helm package --version=SEMVER` param that allows users to
set a version during a package operation.

Closes helm#1480
Closes helm#1699
@technosophos
Copy link
Member

After some debate, I think the current feature will go in with this functionality:

For some package foo, helm package --version 1.2.3 foo will...

  • Generate a package named foo-1.2.3.tgz
  • Set version: 1.2.3 INSIDE of foo-1.2.3
  • Leave the outside foo/Chart.yaml alone

This will prevent CI/CD systems (the envisioned customer of this feature) from choking on a dirty repo after a package command is run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants