Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(package): add value options to 'helm package' #11460

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(package): add value options to 'helm package' #11460

wants to merge 1 commit into from

Conversation

cndoit18
Copy link
Contributor

@cndoit18 cndoit18 commented Oct 21, 2022 •
edited

Signed-off-by: cndoit18 cndoit18@outlook.com

What this PR does / why we need it:
Closes #3141

Special notes for your reviewer:

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 21, 2022
@cndoit18
Copy link
Contributor Author

This PR will solve this comment
#3471 (comment)

@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 21, 2022
@cndoit18 cndoit18 marked this pull request as ready for review October 21, 2022 20:54
@yxxhero
Copy link
Member

yxxhero commented Oct 22, 2022

@cndoit18 good job. I think we should add more descriptions for this PR. Not necessarily familiar with this library sigs.k8s.io/kustomize/kyaml.

yxxhero
yxxhero reviewed Oct 22, 2022
View reviewed changes
cmd/helm/package_test.go Outdated Show resolved Hide resolved
@cndoit18 cndoit18 force-pushed the add-value-options-flags branch 2 times, most recently from 66210f8 to 2921db6 Compare October 22, 2022 06:37
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 22, 2022
@cndoit18 cndoit18 requested a review from yxxhero October 22, 2022 18:38
@cndoit18 cndoit18 mentioned this pull request Oct 22, 2022
Open
@cndoit18 cndoit18 force-pushed the add-value-options-flags branch 2 times, most recently from eed1060 to 794f1c1 Compare October 22, 2022 19:12
yxxhero
yxxhero reviewed Oct 23, 2022
View reviewed changes
pkg/action/package.go Outdated Show resolved Hide resolved
@cndoit18 cndoit18 requested a review from yxxhero October 23, 2022 04:57
@yxxhero yxxhero added this to the 3.11.0 milestone Oct 24, 2022
@dcristobalhMad dcristobalhMad mentioned this pull request Oct 25, 2022
Closed
@mattfarina mattfarina modified the milestones: 3.11.0, 3.12.0 Jan 18, 2023
@ritsuki1227
Copy link

@yxxhero Thank you for reviewing and contributing to Helm, it has been a great help to me! I would appreciate it if this feature could be merged in for the 3.12 release, as it would be very helpful for my project. Thank you again!

@dromadaire54
Copy link

I just want to say that this feature was available in the previous helm version I don't remember the version exactly. I don't know why it has been deleted. This is an important feature for the CI to build helmchart and set the image tag values.

@joejulian joejulian removed this from the 3.12.0 milestone May 5, 2023
@joejulian joejulian added this to the 3.13.0 milestone May 5, 2023
a-palchikov added a commit to a-palchikov/helm that referenced this pull request Jul 4, 2023
@a-palchikov
Cherry-pick changes from helm#11460 to add
2df8d21 
support for --set-xxx for 'helm package'
a-palchikov added a commit to a-palchikov/helm that referenced this pull request Jul 26, 2023
@a-palchikov
Cherry-pick changes from helm#11460 to add
84bdb03 
support for --set-xxx for 'helm package'
@mattfarina mattfarina modified the milestones: 3.13.0, 3.14.0 Sep 25, 2023
@cndoit18 cndoit18 force-pushed the add-value-options-flags branch 2 times, most recently from 4d7d4a2 to f71df54 Compare October 12, 2023 03:08
a-palchikov added a commit to a-palchikov/helm that referenced this pull request Oct 23, 2023
@a-palchikov
Cherry-pick changes from helm#11460 to add
7bbc0bb 
support for --set-xxx for 'helm package'
a-palchikov added a commit to a-palchikov/helm that referenced this pull request Nov 6, 2023
@a-palchikov
Cherry-pick changes from helm#11460 to add
258c2a9 
support for --set-xxx for 'helm package'
@ritsuki1227
Copy link

Is there any plan to merge this PR?
#3141 is one of the most commented open issues in helm. I think many users are awaiting this feature!

@cndoit18
feat(package): add value options to 'helm package'
2070451 
Signed-off-by: cndoit18 <cndoit18@outlook.com>
a-palchikov added a commit to a-palchikov/helm that referenced this pull request Feb 29, 2024
@a-palchikov
Cherry-pick changes from helm#11460 to add
1e21776 
support for --set-xxx for 'helm package'
@mattfarina mattfarina modified the milestones: 3.14.0, 3.15.0 Mar 13, 2024
a-palchikov added a commit to a-palchikov/helm that referenced this pull request Mar 28, 2024
@a-palchikov
Cherry-pick changes from helm#11460 to add
ffa88d0 
support for --set-xxx for 'helm package'
a-palchikov added a commit to a-palchikov/helm that referenced this pull request Apr 8, 2024
@a-palchikov
Cherry-pick changes from helm#11460 to add
9363e47 
support for --set-xxx for 'helm package'
a-palchikov added a commit to a-palchikov/helm that referenced this pull request Apr 22, 2024
@a-palchikov
Cherry-pick changes from helm#11460 to add
f6967e7 
support for --set-xxx for 'helm package'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxxhero yxxhero Awaiting requested review from yxxhero

Assignees
No one assigned
Labels
feature size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
3.15.0
Development

Successfully merging this pull request may close these issues.

add --values and --set flag to helm package
6 participants
@cndoit18 @yxxhero @ritsuki1227 @dromadaire54 @mattfarina @joejulian