Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add --values and --set flag to helm package #3141

Open
sslavic opened this issue Nov 15, 2017 · 81 comments · May be fixed by #11460
Open

add --values and --set flag to helm package #3141

sslavic opened this issue Nov 15, 2017 · 81 comments · May be fixed by #11460
Labels
feature in progress

Comments

@sslavic
Copy link
Contributor

sslavic commented Nov 15, 2017

Just like install and upgrade support --values flag, please support the same for helm package command.

Resulting package archive should contain parent chart's values file merged with any value files provided via --values flag.
@bacongobbler
Copy link
Member

related request: #2566

@sslavic sslavic mentioned this issue Nov 16, 2017
Closed
@adshmh
Copy link
Contributor

adshmh commented Nov 24, 2017

I have started work on this.
Considering the comments on #2566, are we looking for --values or --set (or both?)

@bacongobbler bacongobbler mentioned this issue Nov 27, 2017
Closed
@ngeor
Copy link

ngeor commented Nov 28, 2017

A nice use case is described in the issue I opened ( #3198 ), in which I'd like to be able to do:

helm package --version 1.2.3 --set image.tag 1.2.3

This way the chart version and the docker image version are one and the same.

adshmh added a commit to adshmh/helm that referenced this issue Feb 8, 2018
@adshmh
feat: add --set and --values options to 'helm package'
2007782 
When 'helm package --set stringsArray' is run, this will set/override values
in the packaged chart. 'helm package --values valueFiles' uses one or more
value files to achieve the same.

Closes helm#3141

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
@adshmh adshmh mentioned this issue Feb 8, 2018
Merged
adshmh added a commit to adshmh/helm that referenced this issue Feb 8, 2018
@adshmh
feat: add --set and --values options to 'helm package'
8a5e654 
When 'helm package --set stringsArray' is run, this will set/override values
in the packaged chart. 'helm package --values valueFiles' uses one or more
value files to achieve the same.

Closes helm#3141

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
@adshmh
Copy link
Contributor

adshmh commented Feb 8, 2018

I have just completed the first draft and posted a PR for this.

adshmh added a commit to adshmh/helm that referenced this issue Feb 8, 2018
@adshmh
feat: add --set and --values options to 'helm package'
cad3ef5 
When 'helm package --set stringsArray' is run, this will set/override values
in the packaged chart. 'helm package --values valueFiles' uses one or more
value files to achieve the same.

Closes helm#3141

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
adshmh added a commit to adshmh/helm that referenced this issue Feb 8, 2018
@adshmh
feat: add --set and --values options to 'helm package'
5606493 
When 'helm package --set stringsArray' is run, this will set/override values
in the packaged chart. 'helm package --values valueFiles' uses one or more
value files to achieve the same.

Closes helm#3141

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
@adshmh
Copy link
Contributor

adshmh commented Feb 9, 2018

@ngeor , @sslavic the PR I submitted adds both --set and --values options, could you please take a look?

@ngeor
Copy link

ngeor commented Feb 9, 2018

Hi @adshmh , looks good; unfortunately I don't know Go but I see you covered it with the test cases and all, so it probably does what it says :) Thanks!

@bacongobbler bacongobbler mentioned this issue Feb 19, 2018
Closed
@bacongobbler bacongobbler changed the title add --values flag to helm package add --values and --set flag to helm package Feb 19, 2018
rajatjindal pushed a commit to proofpoint/helm that referenced this issue Feb 24, 2018
@adshmh @rajatjindal
feat: add --set and --values options to 'helm package'
cabeac8 
When 'helm package --set stringsArray' is run, this will set/override values
in the packaged chart. 'helm package --values valueFiles' uses one or more
value files to achieve the same.

Closes helm#3141

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
adshmh added a commit to adshmh/helm that referenced this issue Mar 14, 2018
@adshmh
feat: add --set and --values options to 'helm package'
ff0bfda 
When 'helm package --set stringsArray' is run, this will set/override values
in the packaged chart. 'helm package --values valueFiles' uses one or more
value files to achieve the same.

Closes helm#3141

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
adshmh added a commit to adshmh/helm that referenced this issue Mar 14, 2018
@adshmh
feat: add --set and --values options to 'helm package'
a930eb7 
When 'helm package --set stringsArray' is run, this will set/override values
in the packaged chart. 'helm package --values valueFiles' uses one or more
value files to achieve the same.

Closes helm#3141

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
@cabrinoob
Copy link

When will this feature be available? In 2.9.0 ?

@bacongobbler
Copy link
Member

#3471 missed the deadline for 2.9 so it'll be in 2.10.

@technosophos
Copy link
Member

Re-opening this, as #3471 needs to be backed out.

@technosophos technosophos reopened this Apr 16, 2018
@GKTheOne
Copy link

What does this do to the comments/etc in the archive package? eg, are they stripped or left alone or ??

Currently I'm trying to do the same thing with yq but it just dumps the final values after processing. ie, all the comments, blank lines for organisation, etc are gone.

@bacongobbler
Copy link
Member

#3471 stripped all the comments out, which is why we needed to back that PR out. See #3471 (comment) for more info

@volkodavs
Copy link

Reverted from 2.10 "feat: add --set and --values options to 'helm package'" 7b8aae4

@jdolitsky jdolitsky mentioned this issue Oct 4, 2018
Closed
@FedeBev
Copy link

FedeBev commented Nov 9, 2018

Some news about this?
Thanks

@bacongobbler
Copy link
Member

Same as above; nobody's worked on a follow-up to fix the bugs in #3471 so this has not been implemented. You're more than welcome to fork Helm and compile against #3471 if you're okay with comments being stripped from the values file.

@lyzhang1999
Copy link

Not sure if this will prove useful to anyone else, but I've written a bash script which wraps helm package to allow you to be able to --set values at package time:
https://gist.github.com/duncangrist/211c0be6c30bf53297fc16b2e322dc7f

Example usage:

./helm-package.sh ./my-chart --set image.tag=1.2.3 --app-version=1.2.3 --destination packaged

mark

@github-actions
Copy link

This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Oct 26, 2021
@tychedelia
Copy link
Contributor

tychedelia commented Oct 26, 2021 •
edited

Not stale. For more context, looks like there’s been no progress on upgraded the YAML dependencies required to make this refactor work, as well as questions about whether this can be done in a backwards compatible way.

@github-actions github-actions bot removed the Stale label Oct 27, 2021
@github-actions
Copy link

This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Jan 25, 2022
@solarist
Copy link

Bot please keep it open as this is still a highly requested feature.

@github-actions github-actions bot removed the Stale label Jan 26, 2022
@github-actions
Copy link

This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Apr 26, 2022
@solarist
Copy link

Bot, please.

@hickeyma hickeyma removed the Stale label Apr 26, 2022
@github-actions
Copy link

This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Jul 26, 2022
@dign17
Copy link

dign17 commented Jul 26, 2022

Still would be a nice feature.

@github-actions github-actions bot removed the Stale label Jul 27, 2022
@keskad
Copy link

keskad commented Aug 5, 2022

My use case: Have a generic Helm Chart, parametrize it per application and per environment with values. It would be nice to release a Helm Chart as a whole with values tied to application or even to the environment, so I could fetch it anywhere and test - except database credentials and address for example.

I think it is a very important feature inside an organization, when releasing applications without duplicating the Helm Chart sources.

@cndoit18 cndoit18 linked a pull request Oct 21, 2022 that will close this issue
Open
3 tasks
@cndoit18
Copy link
Contributor

hi, I've posted a PR and fixed the problem of missing comments.

#11460

@keskad
Copy link

keskad commented Oct 31, 2022

I made a temporary workaround using Helm SDK.

https://medium.com/@keska.damian/helm-inside-your-code-helm-sdk-51c0e023f872

@antoniivanov antoniivanov mentioned this issue Dec 2, 2022
Closed
@nschrader nschrader mentioned this issue Dec 9, 2022
Open
@github-actions
Copy link

This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Jan 30, 2023
@joejulian joejulian removed the Stale label Jan 31, 2023
@tuxillo
Copy link

tuxillo commented Mar 3, 2023

Any plans on doing this?

@royalsarkis
Copy link

Any plans on doing this?

You can use "helmer", a script that provides functionality similar to the helm package command, with the added benefit of allowing you to override the values.yaml file
https://github.com/royalsarkis/helmer

@nikola-zapryanov-db
Copy link

6 years and running. Any plans?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(package): add value options to 'helm package' cndoit18/helm