fix(helm): resolve URLs and SemVers correctly #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original dependency resolution did not correctly resolve version or URL of a dependency. Version was tracked by filename, and URL was assumed to be absolute. This fixes both of those. Closes helm#1277
|
LGTM pending CI |
adamreese
reviewed
Oct 6, 2016
| return normalizeURL(repourl, verEntry.URLs[0]) | ||
| } | ||
|
|
||
| return normalizeURL(repourl, verEntry.URLs[0]) |
There was a problem hiding this comment.
how many levels deep are we willing to go to find a chart?
There was a problem hiding this comment.
ALL the way down.
I'll see if I can break that up in a related branch.
There was a problem hiding this comment.
Okay, that change is in #1293, which is directly related to this anyway.
adamreese
reviewed
Oct 6, 2016
| "testing" | ||
|
|
||
| "k8s.io/helm/cmd/helm/helmpath" | ||
| //"k8s.io/helm/pkg/repo" |
There was a problem hiding this comment.
I'll kill that one on a related branch. Good catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original dependency resolution did not correctly resolve version or
URL of a dependency. Version was tracked by filename, and URL was
assumed to be absolute. This fixes both of those.
Closes #1277
This change is