Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): remove the requirement that fetch/install need version #1293

Merged

Conversation

technosophos
Copy link
Member

@technosophos technosophos commented Oct 7, 2016

This removes the requirement that a fetch or install command must
explicitly state the version number to install. Instead, this goes to
the strategy used by OS package managers: Install the latest until told
to do otherwise.

Closes #1198


This change is Reviewable

@technosophos technosophos added this to the 2.0.0-Alpha.5 milestone Oct 7, 2016
@technosophos technosophos self-assigned this Oct 7, 2016
@technosophos technosophos force-pushed the feat/1198-no-version-required branch 2 times, most recently from 4eda5e0 to 193315e Compare October 7, 2016 04:54
@technosophos
Copy link
Member Author

This PR removes the requirement that users supply versions for charts when doing the following operations:

  • helm install
  • helm inspect
  • helm upgrade
  • helm fetch

The new format for a chart reference is REPO_NAME/CHART_NAME:

  • stable/mariadb
  • incubator/mongodb

It is now illegal to supply a version suffix to the chart name (stable/mariadb-0.1.0). To supply a version, use the --version flag:

$ helm install stable/mariadb --version 0.0.9

Other changes in this PR:

  • Docs updated
  • Additional field added to provenance.Verification to disambiguate which file was verified
  • repotest.Server can now replicate a client-side cache (to ease testing)

@technosophos
Copy link
Member Author

Closes #1262

@michelleN
Copy link
Member

michelleN commented Oct 7, 2016

That's one small step for a helm user, one giant leap for the helm user experience.

@michelleN
Copy link
Member

Not a blocker by any means but the first half of the error message is a little unclear.

helm [feat/1198-no-version-required*]$ bin/helm fetch tscharts/alpine --version 3.0.0
Error: chart "alpine" not found in tscharts index. (try 'helm repo update'). No chart version found for alpine-3.0.0

@michelleN
Copy link
Member

Manually tested! Looks good.

@adamreese
Copy link
Member

adamreese commented Oct 7, 2016

probably unrelated, got a mess of extra line returns

% helm install tscharts/alpine
Fetched tscharts/alpine to alpine-0.2.0.tgz
quarreling-but
Last Deployed: Fri Oct  7 10:49:19 2016
Namespace: default
Status: DEPLOYED

Resources:
==> v1/Pod
NAME                       READY     STATUS              RESTARTS   AGE
quarreling-but-my-alpine   0/1       ContainerCreating   0          0s


@adamreese
Copy link
Member

manually tested

This removes the requirement that a fetch or install command must
explicitly state the version number to install. Instead, this goes to
the strategy used by OS package managers: Install the latest until told
to do otherwise.

Closes helm#1198
@technosophos technosophos merged commit 2011788 into helm:master Oct 7, 2016
@technosophos technosophos deleted the feat/1198-no-version-required branch October 28, 2016 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants