Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in docs and fake #3640

Merged
merged 1 commit into from
Mar 10, 2018
Merged

fix typo in docs and fake #3640

merged 1 commit into from
Mar 10, 2018

Conversation

rajatjindal
Copy link
Contributor

got bitten by this today and spent quite some time debugging why my tests were not getting recognized as hooks.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 9, 2018
@rajatjindal
Copy link
Contributor Author

@technosophos Hi Matt, can you please review this and provide your feedback.

Copy link
Contributor

@thomastaylor312 thomastaylor312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good eye. I'll go ahead and merge this. Thank you!

@thomastaylor312 thomastaylor312 merged commit c5f2174 into helm:master Mar 10, 2018
@rajatjindal rajatjindal deleted the docfix branch March 10, 2018 02:51
splisson pushed a commit to splisson/helm that referenced this pull request Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants