Fix incorrect timestamp when helm package #4161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The files contained in the `tar` file from `helm package` did not have the correct timestamp. This lack of timestamp occurred because we were not writing any time to the tar header file.
k8s-ci-robot
added
cncf-cla: yes
bacongobbler
approved these changes
Jun 8, 2018
|
cc @adamreese, think we want to make a patch to Helm 3 with this fix? |
bacongobbler
added
the
v3.x
Hiruma31
added a commit
to Hiruma31/helm
that referenced
this pull request
Dec 19, 2019
Signed-off-by: Romain Grenet <romain.grenet@gmail.com>
Hiruma31
added a commit
to Hiruma31/helm
that referenced
this pull request
Dec 19, 2019
Signed-off-by: Romain Grenet <romain.grenet@gmail.com>
Hiruma31
added a commit
to Hiruma31/helm
that referenced
this pull request
Dec 19, 2019
Lint CRLF Signed-off-by: Romain Grenet <romain.grenet@gmail.com>
Hiruma31
added a commit
to Hiruma31/helm
that referenced
this pull request
Dec 19, 2019
Lint CRLF Signed-off-by: Romain Grenet <romain.grenet@gmail.com>
bacongobbler
pushed a commit
that referenced
this pull request
Dec 19, 2019
Port PR #4161 to Helmv3 - Fix incorrect timestamp when helm package
mattfarina
pushed a commit
that referenced
this pull request
Jan 28, 2020
Lint CRLF Signed-off-by: Romain Grenet <romain.grenet@gmail.com> (cherry picked from commit 8cb3c02)
bamachrn
pushed a commit
to bamachrn/helm
that referenced
this pull request
Feb 28, 2020
Lint CRLF Signed-off-by: Romain Grenet <romain.grenet@gmail.com>
bamachrn
pushed a commit
to bamachrn/helm
that referenced
this pull request
Feb 28, 2020
Lint CRLF Signed-off-by: Romain Grenet <romain.grenet@gmail.com>
bamachrn
pushed a commit
to bamachrn/helm
that referenced
this pull request
Feb 28, 2020
Lint CRLF Signed-off-by: Romain Grenet <romain.grenet@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4158
The files contained in the
tarfile fromhelm packagedid not havethe correct timestamp. This lack of timestamp occurred because we were
not writing any time to the tar header file.