make get script sudo optional #4677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rimas <rmocius@gmail.com>
|
This was implemented in #4649. You can use the |
|
another option using the env var |
|
@rimusz Are you asking that the choice to use sudo or not be exposed as an environment variable in addition to a flag? Is that what this PR is intended to solve? |
bacongobbler
approved these changes
Nov 7, 2018
splisson
pushed a commit
to splisson/helm
that referenced
this pull request
Dec 6, 2018
Signed-off-by: rimas <rmocius@gmail.com> Signed-off-by: Sebastien Plisson <sebastien.plisson@gmail.com>
splisson
pushed a commit
to splisson/helm
that referenced
this pull request
Dec 6, 2018
Signed-off-by: rimas <rmocius@gmail.com> Signed-off-by: Sebastien Plisson <sebastien.plisson@gmail.com>
splisson
pushed a commit
to splisson/helm
that referenced
this pull request
Dec 6, 2018
Signed-off-by: rimas <rmocius@gmail.com>
splisson
pushed a commit
to splisson/helm
that referenced
this pull request
Dec 6, 2018
Signed-off-by: rimas <rmocius@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rimas rmocius@gmail.com