-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the _proto directory #4756
Document the _proto directory #4756
Conversation
b6a9b9b
to
0c5914b
Compare
Signed-off-by: Timothy Hobbs <timothy@hobbs.cz>
0c5914b
to
45f388f
Compare
I wonder why the contents of I also don't understand why the rudder directory is not in the services directory when it is in the services package. |
Can someone with the correct credentials hit the rebuild button? I don't think that should be failing. |
Just as a note, we do make a note of this in the developer's guide, though I can see why a README may be useful. |
The README would not be nearly as useful if the directory name did not start with an underscore and was instead something descriptive like |
There is only one other directory which has an unclear name, |
Signed-off-by: Timothy Hobbs <timothy@hobbs.cz> Signed-off-by: Sebastien Plisson <sebastien.plisson@gmail.com>
Signed-off-by: Timothy Hobbs <timothy@hobbs.cz> Signed-off-by: Sebastien Plisson <sebastien.plisson@gmail.com>
Signed-off-by: Timothy Hobbs <timothy@hobbs.cz>
Signed-off-by: Timothy Hobbs <timothy@hobbs.cz>
I'm only guessing on the use of the rudder service definition. I tried googling to no avail and neither https://github.com/timthelion/helm/blob/master/_proto/hapi/rudder/rudder.proto nor https://github.com/helm/helm/blob/master/cmd/rudder/rudder.go explain it.