docs(helm): Mention commit signing in the Developer Guide #5018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
size/XS
bacongobbler
changed the title
|
there's a slight typo in your commit message if you wanna fix that. "dosc" should be "docs". Otherwise LGTM |
|
@bacongobbler well spotted, fix on its way |
This change adds a mention to the reqruiement for commit signing to the Git Convention outline in the Developer Guide, while leaving the existing detail on signing in the Contributing doc. Closes helm#5016 Signed-off-by: Henry Nash <henry.nash@uk.ibm.com>
henrynash
force-pushed
the
docs/mention-signing
branch
from
45eacd8
to
4880a6e
Compare
helm-bot
added
size/XS
bacongobbler
approved these changes
Dec 5, 2018
splisson
pushed a commit
to splisson/helm
that referenced
this pull request
Dec 6, 2018
This change adds a mention to the reqruiement for commit signing to the Git Convention outline in the Developer Guide, while leaving the existing detail on signing in the Contributing doc. Closes helm#5016 Signed-off-by: Henry Nash <henry.nash@uk.ibm.com> Signed-off-by: Sebastien Plisson <sebastien.plisson@gmail.com>
splisson
pushed a commit
to splisson/helm
that referenced
this pull request
Dec 6, 2018
This change adds a mention to the reqruiement for commit signing to the Git Convention outline in the Developer Guide, while leaving the existing detail on signing in the Contributing doc. Closes helm#5016 Signed-off-by: Henry Nash <henry.nash@uk.ibm.com> Signed-off-by: Sebastien Plisson <sebastien.plisson@gmail.com>
splisson
pushed a commit
to splisson/helm
that referenced
this pull request
Dec 6, 2018
This change adds a mention to the reqruiement for commit signing to the Git Convention outline in the Developer Guide, while leaving the existing detail on signing in the Contributing doc. Closes helm#5016 Signed-off-by: Henry Nash <henry.nash@uk.ibm.com>
splisson
pushed a commit
to splisson/helm
that referenced
this pull request
Dec 6, 2018
This change adds a mention to the reqruiement for commit signing to the Git Convention outline in the Developer Guide, while leaving the existing detail on signing in the Contributing doc. Closes helm#5016 Signed-off-by: Henry Nash <henry.nash@uk.ibm.com>
consolewitch
pushed a commit
to consolewitch/helm
that referenced
this pull request
Jan 7, 2019
This change adds a mention to the reqruiement for commit signing to the Git Convention outline in the Developer Guide, while leaving the existing detail on signing in the Contributing doc. Closes helm#5016 Signed-off-by: Henry Nash <henry.nash@uk.ibm.com>
eraac
pushed a commit
to eraac/helm
that referenced
this pull request
Mar 21, 2019
This change adds a mention to the reqruiement for commit signing to the Git Convention outline in the Developer Guide, while leaving the existing detail on signing in the Contributing doc. Closes helm#5016 Signed-off-by: Henry Nash <henry.nash@uk.ibm.com> Signed-off-by: Kevin Labesse <kevin@labesse.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a mention to the requirement for commit signing
to the Git Convention outline in the Developer Guide, while
leaving the existing detail on signing in the Contributing doc.
Closes #5016
Signed-off-by: Henry Nash henry.nash@uk.ibm.com