Fixes #5046, zsh completion

[Sarke]

Signed-off-by: Peter Stalman sarkedev@gmail.com

What this PR does / why we need it:
Closes #5046

Special notes for your reviewer:
Small fix. Removes quotes in aliashash keys to work with ZSH.

If applicable:

• this PR contains documentation
• this PR contains unit tests
• this PR has been tested for backwards compatibility

[kalinon]

Unfortunately this did not solve my ZSH bash error:

./bin/helm ins_helm_root_command:12: bad math expression: operand expected at `"del"'                                                             130 ↵
_helm_root_command:12: bad math expression: operand expected at `"del"'
_helm_root_command:12: bad math expression: operand expected at `"del"'
./bin/helm

This seems to be an issue with the OSX version of sed:

$ helm completion zsh | sed -e 's/aliashash\["\(\w\+\)"\]/aliashash[\1]/g' | grep aliashash  
	-e 's/aliashash\["\(\w\+\)"\]/aliashash[\1]/g' \
        # aliashash variable is an associative array which is only supported in bash > 3.
            words[c]=${aliashash[${words[c]}]}
        aliashash["ls"]="list"
        aliashash["up"]="update"
        aliashash["rm"]="remove"
        aliashash["up"]="update"
        aliashash["del"]="delete"
        aliashash["dep"]="dependency"
        aliashash["dependencies"]="dependency"
        aliashash["hist"]="history"
        aliashash["ls"]="list"
    declare -A aliashash 2>/dev/null || :
$ sed --help
sed: illegal option -- -
usage: sed script [-Ealn] [-i extension] [file ...]
       sed [-Ealn] [-i extension] [-e script] ... [-f script_file] ... [file ...]

However GNU sed seems to work:

$ gsed -E 's/aliashash\["(\w+)"\]/aliashash[\1]/g' ./comp.sh | grep aliashash
	-e 's/aliashash\["\(\w\+\)"\]/aliashash[\1]/g' \
        # aliashash variable is an associative array which is only supported in bash > 3.
            words[c]=${aliashash[${words[c]}]}
        aliashash[ls]="list"
        aliashash[up]="update"
        aliashash[rm]="remove"
        aliashash[up]="update"
        aliashash[del]="delete"
        aliashash[dep]="dependency"
        aliashash[dependencies]="dependency"
        aliashash[hist]="history"
        aliashash[ls]="list"
    declare -A aliashash 2>/dev/null || :
$ gsed --version
gsed (GNU sed) 4.7

[kalinon]

This sed seems to work with BSD sed:

helm completion zsh | sed -e "s/aliashash\\[\"\\(${LWORD}.*${RWORD}\\)\"\\]/aliashash[\\1]/g" | grep aliashash
	-e 's/aliashash\["\([[:<:]].*[[:>:]]\)"\]/aliashash[\1]/g' \
        # aliashash variable is an associative array which is only supported in bash > 3.
            words[c]=${aliashash[${words[c]}]}
        aliashash[ls]="list"
        aliashash[up]="update"
        aliashash[rm]="remove"
        aliashash[up]="update"
        aliashash[del]="delete"
        aliashash[dep]="dependency"
        aliashash[dependencies]="dependency"
        aliashash[hist]="history"
        aliashash[ls]="list"
    declare -A aliashash 2>/dev/null || :

Changing the line to use the word boundaries should make this compatible for others:

"s/aliashash\\[\"\\(${LWORD}.*${RWORD}\\)\"\\]/aliashash[\\1]/g"

[philoserf]

I believe the answer is to revert
#4851

[Sarke]

@philoserf, that will only break the ZSH completion. So yes, you wouldn't get the error, but you would also not get any completion.

The issue is the introduction of the shorter aliases for bash, which are not correctly converted to to ZSH.

[marckhouzam]

Turns out that the real root of this bug was that the 'aliashash' associative array was not being declared properly. PR #5680 fixes it and removes this fix, which is no longer needed.

[marckhouzam]

And the saga continues. It seems that removing the quotes is necessary but for a completely different reason. See 48f0e31 for details.