Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Support local tgz install & tgz with directory #5627

Closed

Conversation

steven-sheehy
Copy link

@steven-sheehy steven-sheehy commented Apr 22, 2019

What this PR does / why we need it:
Closes #5540

Enhancements:

  • Adds support for local installation of tgz files
  • Adds support for tgz files with directories (i.e. non-tarbombs)

Bug fixes:

  • Ensure gzip reader is closed after use
  • Ensure creation of the plugin cache directory is successful before extracting plugin
  • Ensure extracted files get created with the correct permission from the tar header (this fixes executable files not having execute permission)

Special notes for your reviewer:

  • Moves Extractor to separate file for re-use between local and HTTP installers
  • Detects directory of plugin.yaml in extracted hierarchy and adjusts the plugin path accordingly

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@helm-bot helm-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 22, 2019
Signed-off-by: Steven Sheehy <ssheehy@firescope.com>
@steven-sheehy steven-sheehy changed the title Plugin: Support local tgz install & non-tarbombs Plugin: Support local tgz install & tgz with directory Apr 25, 2019
@steven-sheehy
Copy link
Author

@thomastaylor312 @bacongobbler Would this be more appropriate for helm v3?

@thomastaylor312
Copy link
Contributor

@steven-sheehy given all of the maintainer's focus on helm 3, I think it probably would be more appropriate for Helm 3

@bacongobbler
Copy link
Member

closing as the action item is to implement this for Helm 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm plugin install tgz with directory
4 participants