Update Cobra to 1.0.0 release #7904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
helm-bot
added
the
size/M
jdolitsky
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cobra has just done their 1.0.0 release: https://github.com/spf13/cobra/releases/tag/v1.0.0 🎉
The major change since the version we currently use (
0.0.5) is actually the support for Custom Go Completions and Fish completions, based on what was done for Helm.The only other noticeable change is:
which is fully-backwards compatible. So I'm confident this PR is safe to take in.
This PR is the first step in making use of Cobra's new Custom Go Completions and dropping all that code from Helm.