-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support to pass values to sub-charts via map.yaml
#8580
Conversation
Signed-off-by: Jorge C. Leitao <jorgecarleitao@gmail.com>
As a note, by doing this work in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jorgecarleitao. We're asking new proposals to first write up a Helm Improvement Proposal, also known as a HIP. This gives the maintainers an opportunity to consider the design of the proposal and iron out any design kinks before a reference implementation is provided. This saves both you and us time in the long run.
Please have a read through https://github.com/helm/community/blob/master/hips/hip-0001.md and let me know if you have any questions.
any progress on this? |
No further progress has been made since chnages were requested 12 months ago. Closing as stale. |
@jorgecarleitao please don't give up. :) |
Expecting anyone who is capable and willing to write code (for free) to write an HIP document instead is nuts. Like 100% nuts. If you have a problem where people are writing code that seems like it is coming out of left field, then you have lost touch with your user base, not the other way around. |
What this PR does / why we need it:
This PR allows developers to declare a
map.yaml
file on their chart, which can be used to map values invalues.yaml
to derived values that are used in templating, including sub-charts (see #8576 for the long explanation). This allows developers to write e.g.thereby not having to expose
backend: uri
,frontend: uri
invalues.yaml
(for the subchart), nor ask chart users to have to pass the same value in multiple keys for consistency (or use global names that lead to naming collisions).I.e. it allows subcharts to be populated with derived (or
map
ed) values without exposing these values tovalues.yaml
(the public interface of the chart).This solves a long standing issue of being very painful to pass values to subcharts that derive values in
values.yaml
(more details in #8576). Closes #8576.Special notes for your reviewer: This PR is not complete yet: this is part of the proposal, and is intended to demonstrate how the proposal is implemented in practice. There are at least three issues to address, two documented as
# todo
, plus associated documentation.To run the example,
which leads to the manifest
If applicable: