Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validate the name passed in during helm create #8750

Merged
merged 1 commit into from
Sep 17, 2020
Merged

validate the name passed in during helm create #8750

merged 1 commit into from
Sep 17, 2020

Conversation

technosophos
Copy link
Member

Signed-off-by: Matt Butcher matt.butcher@microsoft.com

What this PR does / why we need it:

Improve validation of chart during helm create

Special notes for your reviewer:

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@technosophos
validate the name passed in during helm create
c4ef82b 
Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>
@technosophos technosophos added the needs-pick Indicates that a PR needs to be cherry-picked into the next release candidate. label Sep 17, 2020
@technosophos technosophos added this to the 3.3.2 milestone Sep 17, 2020
@technosophos technosophos self-assigned this Sep 17, 2020
@helm-bot helm-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 17, 2020
@mattfarina mattfarina merged commit 11f75e4 into helm:master Sep 17, 2020
@mattfarina mattfarina added the picked Indicates that a PR has been cherry-picked into the next release candidate. label Sep 17, 2020
@wawa0210 wawa0210 mentioned this pull request Jan 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattfarina mattfarina mattfarina approved these changes

@bacongobbler bacongobbler bacongobbler approved these changes

Assignees

@technosophos technosophos

Labels
needs-pick Indicates that a PR needs to be cherry-picked into the next release candidate. picked Indicates that a PR has been cherry-picked into the next release candidate. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
3.3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@technosophos @mattfarina @bacongobbler @helm-bot