Cleanup tempfiles #8829
Open
Cleanup tempfiles #8829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
size/M
zhijianli88
force-pushed
the
cleanup-tempfiles
branch
from
2a06251
to
e937e45
Compare
|
Kindly ping |
Previously, after 'make test', some many temp dir have not been removed. Since this commit, temp dir created by ensure.HelmHome() ensure.TempDir() and ensure.TempFile() will be removed automatically in the end of testing - Use T.cleanup to remove the tempdir - Remove unnecessary defer Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
As suggestion by Paul Brousseau, It might be useful to leave the directory in place if the test fails. Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
these tests will dirty the HelmHome Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
zhijianli88
force-pushed
the
cleanup-tempfiles
branch
from
e937e45
to
6734887
Compare
|
i just rebased the PR, anyone could help to have a review ? |
|
Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the PR, we can cleanup all remaining tempdir
lizj@FNSTPC:~/workspace/k8s/helm$ export TMPDIR=/tmp/xxxxxx ; make clean; make test >/dev/null && echo PASS; ls -l $TMPDIR
PASS
total 0