Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup tempfiles #8829

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Cleanup tempfiles #8829

wants to merge 3 commits into from

Commits on Jan 12, 2021

  1. testing: Use T.cleanup() to cleanup tempdir 

    Previously, after 'make test', some many temp dir have not been removed.
Since this commit, temp dir created by ensure.HelmHome()
ensure.TempDir() and ensure.TempFile() will be removed automatically in
the end of testing

- Use T.cleanup to remove the tempdir
- Remove unnecessary defer

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
    @zhijianli88
    zhijianli88 committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    3350760 View commit details
    Browse the repository at this point in the history

  2. testing: Don't cleanup tempfiles if the test failed 

    As suggestion by Paul Brousseau, It might be useful to leave the directory in
place if the test fails.

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
    @zhijianli88
    zhijianli88 committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    6230cb9 View commit details
    Browse the repository at this point in the history

  3. testing: setup a temp HelmHome for a few tests 

    these tests will dirty the HelmHome

Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
    @zhijianli88
    zhijianli88 committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    6734887 View commit details
    Browse the repository at this point in the history