bug: Fix comparing GVK of resources in a ResourceList #9701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tamal Saha <tamal@appscode.com>
helm-bot
added
the
size/XS
tamalsaha
changed the title
bacongobbler
requested changes
May 26, 2021
There was a problem hiding this comment.
Tests are required. Please write a unit test describing the issue at-hand and why this change resolves it. If an issue does not exist, please create one as well.
An explanation why the current APIs do not work along with any tradeoffs with the proposed change is also appreciated.
Thanks.
|
closing as inactive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tamal Saha tamal@appscode.com
What this PR does / why we need it:
This PR fixes a bug where api group was not considered when comparing a resource.
Special notes for your reviewer:
If applicable: