Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

SVG icons are not displayed #577

Closed
lambertjosh opened this issue Dec 12, 2018 · 1 comment · Fixed by #631
Closed

SVG icons are not displayed #577

lambertjosh opened this issue Dec 12, 2018 · 1 comment · Fixed by #631

Comments

@lambertjosh
Copy link

First, thanks for this great project! In doing a bit of testing, our gitlab chart uses an SVG for its icon. Unfortunately it is not displayed: https://hub.helm.sh/charts/gitlab/gitlab

According to the spec, SVG's are supported: https://github.com/helm/helm/blob/master/docs/charts.md#the-chartyaml-file

Would be great if SVG's were shown!

@prydonius
Copy link
Member

prydonius commented Dec 17, 2018

Thanks for the bug, this would be really cool! We currently download the icons and post-process them (currently just converting to PNG and resizing to 160x160 https://github.com/helm/monocular/blob/master/cmd/chart-repo/utils.go#L300), so we would need to change this to either convert the SVG to PNG so everything else stays the same, or store the SVGs and display them differently in the frontend. I'm not sure we really need to preserve the SVG, so converting to PNG might be the simplest option, but I'm not sure if there are any side effects from doing that conversion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants