Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict-Transport-Security middleware should throw, not warn, when misspelling "includeSubDomains" option #462

Closed
EvanHahn opened this issue Apr 27, 2024 · 2 comments

Comments

@EvanHahn
Copy link
Member

This should throw instead:

if ("includeSubdomains" in options) {
console.warn(
'Strict-Transport-Security middleware should use `includeSubDomains` instead of `includeSubdomains`. (The correct one has an uppercase "D".)',
);
}

To fix this, we should:

  1. Update these lines to throw, not warn.
  2. Fix the tests.

This change should be opened against the v8.0.0 branch, not main.

@sohrb
Copy link

sohrb commented Apr 28, 2024

Here is the PR

EvanHahn pushed a commit that referenced this issue Apr 28, 2024
@EvanHahn
Copy link
Member Author

Done in 2ccdab6. Thanks, @sohrb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants