Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strict transport security middleware error #464

Merged
merged 2 commits into from
Apr 28, 2024
Merged

Strict transport security middleware error #464

merged 2 commits into from
Apr 28, 2024

Conversation

sohrb
Copy link

@sohrb sohrb commented Apr 28, 2024

Issue #462

  • Replace console.warn with throw new Error
  • Update tests to expect error to be thrown rather than the console to warn

@sohrb sohrb mentioned this pull request Apr 28, 2024
Closed
@EvanHahn EvanHahn merged commit 2ccdab6 into helmetjs:v8.0.0 Apr 28, 2024
EvanHahn pushed a commit that referenced this pull request Apr 28, 2024
@sohrb @EvanHahn
HSTS: throw when misspelling "includeSubDomains" option
433e348 
See [#462] and [#464].

[#462]: #462
[#464]: #464
@sohrb sohrb deleted the strict-transport-security-middleware-error branch May 1, 2024 20:22
EvanHahn pushed a commit that referenced this pull request May 25, 2024
@sohrb @EvanHahn
HSTS: throw when misspelling "includeSubDomains" option
d365e9e 
See [#462] and [#464].

[#462]: #462
[#464]: #464
EvanHahn pushed a commit that referenced this pull request Jun 1, 2024
@sohrb @EvanHahn
HSTS: throw when misspelling "includeSubDomains" option
8d493c9 
See [#462] and [#464].

[#462]: #462
[#464]: #464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sohrb @EvanHahn