Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license attribute #99

Merged
merged 1 commit into from
May 20, 2015
Merged

Add license attribute #99

merged 1 commit into from
May 20, 2015

Conversation

pdehaan
Copy link
Contributor

@pdehaan pdehaan commented May 20, 2015

specifying the type and URL is deprecated:

https://docs.npmjs.com/files/package.json#license
http://npm1k.org/

EvanHahn added a commit that referenced this pull request May 20, 2015
@EvanHahn EvanHahn merged commit ce2dd84 into helmetjs:master May 20, 2015
@EvanHahn
Copy link
Member

Didn't realize we were missing this—thank you!

@EvanHahn
Copy link
Member

EvanHahn commented Aug 5, 2016

@pdehaan I'm making a new website for Helmet.js and I want to credit everyone who's contributed. Do you have a name and/or website you'd like me to use to credit you?

@pdehaan
Copy link
Contributor Author

pdehaan commented Aug 5, 2016

Nope. No credit necessary. I could almost literally have done any less.

PS: Love the project, thanks for keeping it moving forward! 😍

@pdehaan pdehaan deleted the patch-1 branch August 5, 2016 19:36
@EvanHahn
Copy link
Member

EvanHahn commented Aug 5, 2016

Alright, if you insist. Thanks again for your fix (and for liking Helmet)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants