This repository has been archived by the owner on Jun 18, 2020. It is now read-only.
Rewrite module in TypeScript #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanHahn
commented
Mar 8, 2019
EvanHahn
commented
Mar 8, 2019
EvanHahn
commented
Mar 8, 2019
EvanHahn
commented
Mar 8, 2019
sandersn
approved these changes
Mar 8, 2019
|
This seems reasonably ready to go. Gonna let this simmer for a bit (in case anyone else wants to review) before I merge and deploy. |
|
This has been deployed in @sandersn Thanks for your help! Please add yourself to the contributors list when you have a moment (or let me know your name and, optionally, a URL). |
|
OK. The PR is #3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See helmetjs/helmet#188.
This branch rewrites the module in TypeScript. I am familiar with TypeScript but not its best practices so I'd love some 👀 on this.