Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup and dependency updates #37

Open
wants to merge 9 commits into
base: chore/squeeze-jit
Choose a base branch
from

Conversation

axisiscool
Copy link

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Apr 22, 2022

This pull request fixes 1 alert when merging d9aebab into 1103604 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 22, 2022

This pull request fixes 1 alert when merging db63031 into 1103604 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 22, 2022

This pull request fixes 1 alert when merging 6788fb1 into 1103604 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 22, 2022

This pull request fixes 1 alert when merging 77256c4 into 1103604 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@axisiscool
Copy link
Author

@Nytelife26 Mr. Russell please review

This commit also removes node 12 testing workflow because petitio doesn't support it
@lgtm-com
Copy link

lgtm-com bot commented Apr 22, 2022

This pull request fixes 1 alert when merging e4907aa into 1103604 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 22, 2022

This pull request fixes 1 alert when merging 80b2ea8 into 1103604 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

.github/workflows/ci-lint-test.yml Show resolved Hide resolved
src/lib/PetitioRequest.ts Outdated Show resolved Hide resolved
src/lib/PetitioRequest.ts Outdated Show resolved Hide resolved
src/lib/PetitioRequest.ts Outdated Show resolved Hide resolved
"target": "ES2015",
"target": "ES2021",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one concerns me. I'm fairly sure the target was set this way to compile for Node 14 or similar, I'll wait for CI before continuing.

src/lib/PetitioResponse.ts Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Apr 23, 2022

This pull request fixes 1 alert when merging e7a3632 into 1103604 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@axisiscool
Copy link
Author

@Nytelife26 Could you possibly approve the workflows?

@axisiscool
Copy link
Author

@tbnritzdoge these workflows are taking a little while to run, don't u think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants