Skip to content

Commit

Permalink
Add quotations to the id of the gist helper
Browse files Browse the repository at this point in the history
The test code for the gist helper surrounds the id with quotation marks
to treat the id as a string but the documentation and function
description do not. Implementing the example without quotation marks
results in <script src="https://gist.github.com/undefined.js"></script>
being returned.
  • Loading branch information
nathanjessen committed Jan 6, 2017
1 parent d9697cf commit 573cad9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,7 @@ Embed a GitHub Gist using only the id of the Gist
**Example**

```handlebars
{{gist 12345}}
{{gist "12345"}}
```

### [{{jsfiddle}}](lib/code.js#L72)
Expand Down Expand Up @@ -2504,4 +2504,4 @@ Released under the [MIT license](https://github.com/assemble/handlebars-helpers/

***

_This file was generated by [verb-generate-readme](https://github.com/verbose/verb-generate-readme), v0.1.30, on August 17, 2016._
_This file was generated by [verb-generate-readme](https://github.com/verbose/verb-generate-readme), v0.1.30, on August 17, 2016._
2 changes: 1 addition & 1 deletion lib/code.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ helpers.embed = function embed(fp, ext) {
* Embed a GitHub Gist using only the id of the Gist
*
* ```handlebars
* {{gist 12345}}
* {{gist "12345"}}
* ```
* @param {String} `id`
* @return {String}
Expand Down

0 comments on commit 573cad9

Please sign in to comment.