Add combineAppRoutes util #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update adds a new combineAppRoutes utility function. This enables Marionette apps to render a React Router powered component/app. It works by combining React routes and Marionette Routes to a flat object for Marionette's appRouter. The trick is to have the React routes end with `*notFound`, which kind of functions like a wild card match. It's an unfortunate thing, but it's the only thing that seems to work.
knicklabs
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add combineAppRoutes util
This update adds a new combineAppRoutes utility function. This enables Marionette
apps to render a React Router powered component/app. It works by combining React
routes and Marionette Routes to a flat object for Marionette's appRouter.
The trick is to have the React routes end with
*notFound, which kind of functionslike a wild card match.
It's an unfortunate thing, but it's the only thing that seems to work.