FrameManager: Fix IE/Edge frame rendering #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update fixes the iFrame `SCRIPT70` error that occurs in IE/Edge when an iFrame unmounts/remounts. The solution was to wrap the offending code in a `try/catch`. The code in question is designed for performance, specifically to check for cached instances of Emotion, and serves that instance instead of creating a brand new one. The caching mechanism will work for all browsers excluding IE/Edge, which unfortunately, will create new emotion instances every time as unmounted frames cannot be properly references.
tinkertrain
approved these changes
Nov 7, 2018
|
@tinkertrain Thank you!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FrameManager: Fix IE/Edge frame rendering
(GIF: Demo'ing Frame 1 being unmounted (destroy) and remounted in Edge. No errors in console. Stays are working)
This update fixes the iFrame
SCRIPT70error that occurs in IE/Edgewhen an iFrame unmounts/remounts.
The solution was to wrap the offending code in a
try/catch.The code in question is designed for performance, specifically to check
for cached instances of Emotion, and serves that instance instead of
creating a brand new one.
The caching mechanism will work for all browsers excluding IE/Edge, which
unfortunately, will create new emotion instances every time as unmounted
frames cannot be properly references.
Tested on Edge, IE, and Chrome