Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FrameManager: Fix IE/Edge frame rendering #33

Merged
merged 1 commit into from
Nov 7, 2018

Commits on Nov 6, 2018

  1. FrameManager: Fix IE/Edge frame rendering

    This update fixes the iFrame `SCRIPT70` error that occurs in IE/Edge
    when an iFrame unmounts/remounts.
    
    The solution was to wrap the offending code in a `try/catch`.
    
    The code in question is designed for performance, specifically to check
    for cached instances of Emotion, and serves that instance instead of
    creating a brand new one.
    
    The caching mechanism will work for all browsers excluding IE/Edge, which
    unfortunately, will create new emotion instances every time as unmounted
    frames cannot be properly references.
    Jon Q committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    dfcefea View commit details
    Browse the repository at this point in the history