Promoting v2 to master #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use guzzle, update creation workflow, fix tests, use Auth objects * Use invokable classes for handlers * Fix tests and update readme * Tell PHP Stan to ignore mock interface being given as argument * Add codeclimate test coverage * Codeclimate * Adjust code coverage target * Forgot to add target to command * Update config * More config fun * Add retry decider * Clean up composer deps * PHP Version * Fix sniff errors * Remove artifact * Fix typehint error * Skip step and assign to property without intermediate variable * Add documentation for the mock method
* Remove HTTPlug Guzzle adapter as a suggestion * Remove HTTPlug common client as a dependency * Format code
* update travis and composer * Update readme, too * Set minimum-stability and remove need for psr/container
* Add conversation filter for customFieldIds and update readme * Update conversation example * Add return type-hints * Update method names
* Add convenience methods and make setters fluent * Add fluent setters and type-hints to customer
* Ensure that either customer ID or customer email are present * Fix sniff errors * Consolidate logic into trait * Fix getFirstEmail and update test to pass email object into collection * Add convenience methods and make setters fluent (#82) * Add convenience methods and make setters fluent * Add fluent setters and type-hints to customer * Ensure that either customer ID or customer email are present * Fix sniff errors * Consolidate logic into trait * Fix getFirstEmail and update test to pass email object into collection * Update composer and re-run fix command
Updating parameter names according the code: https://github.com/helpscout/helpscout-api-php/blob/v2/src/Http/RestClientBuilder.php#L93
* Updated serialization to handle both HasMany and HasOne embedded entities * Added customers example * Customer embedded entities are now properly eagerly populated * Deprecating CustomerRequest since all entities are eager loaded * Clarifying this applies to both collections and single objects
* Hydrating Users as the Conversation's createdBy now hydrates the name correctly * hydrating the id is now optional
* Add deprecation notices to indicate that LegacyCredentials and transition service will no longer function when v1 sunsets. * Fix style issues * Added deprecation notice to useLegacyToken()
* Beginning support for authorization code flow (#107) * Adding support for authorization code flow * Correcting whitespaces (I hate whitespaces :D) * Adding useCodeToken() method into ApiClient * Allow an authorization code to be easily exchanged for tokens * Expanded on docs to provide clarity on what auth is used when * phpcs
* Removing previously missed CustomerRequest usage * Deprecated "Chat" in favor of "ChatHandle"
* Flagging the legacy token conversion method as deprecated * Reworked phrasing
* Customer id and email now included in extraction * No longer including empty array values for extracted Customers * Now using generic Customer extraction for easier Customer creation * Updating method name * Added example for how to create a Customer * Removing null values
* Add methods to process incoming webhooks * Fix style issues * Add tests * Add continue statement and use other header type * Update readme * Add example
davidstanley01
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@davidstanley01 has already archived
masterin av1branch and released v1.9.5 targeting that branch. This PR promotes v2 to be the newmaster, and thus the default documentation that will be seen when developers check out our SDK.