Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify client instantiation #70

Merged
merged 18 commits into from
Dec 18, 2018
Merged

Simplify client instantiation #70

merged 18 commits into from
Dec 18, 2018

Conversation

davidstanley01
Copy link
Contributor

This PR simplifies the way we instantiate the client. To do this, I've swapped the HTTPlug stuff for just using guzzle. Along the way, I ported the plugins to be handlers in guzzle and also updated the tests and stuff to match. I've added integration with CodeClimate and test coverage provide by Travis (via CodeClimate). Finally, I've added a retry handler to the client with exponential backoff. All good.

Copy link
Contributor

@bkuhl bkuhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good. Could you add some documentation surrounding the mocking functionality?

README.md Show resolved Hide resolved
src/Http/Authenticator.php Outdated Show resolved Hide resolved
@davidstanley01
Copy link
Contributor Author

I've added a blurb to the readme about how to use the mock($endpoint) method on the ApiClient class.

README.md Show resolved Hide resolved
@bkuhl bkuhl merged commit 29c246d into v2 Dec 18, 2018
@bkuhl bkuhl deleted the simplify branch December 18, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants