Add support for additional user fields #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyterrell
force-pushed
the
add-support-for-additional-user-fields
branch
2 times, most recently
from
f9ec2ff
to
84359f5
Compare
anthonyterrell
force-pushed
the
add-support-for-additional-user-fields
branch
from
84359f5
to
49d8007
Compare
anthonyterrell
changed the title
bkuhl
requested changes
Jan 3, 2020
There was a problem hiding this comment.
This looks great! Could you also update https://github.com/helpscout/helpscout-api-php/blob/master/tests/Payloads/UserPayloads.php#L63-L82 to reflect the added fields as well?
ShayCichocki
approved these changes
Jan 3, 2020
bkuhl
approved these changes
Jan 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #211
This pull request adds getters and setters for additional User fields: jobTitle, phone, alternativeEmails.