Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for additional user fields #220

Merged
merged 4 commits into from Jan 3, 2020

Conversation

@anthonyterrell
Copy link
Contributor

anthonyterrell commented Jan 2, 2020

Closes #211

This pull request adds getters and setters for additional User fields: jobTitle, phone, alternativeEmails.

@anthonyterrell anthonyterrell force-pushed the add-support-for-additional-user-fields branch 2 times, most recently from f9ec2ff to 84359f5 Jan 2, 2020
@anthonyterrell anthonyterrell force-pushed the add-support-for-additional-user-fields branch from 84359f5 to 49d8007 Jan 2, 2020
@anthonyterrell anthonyterrell requested a review from bkuhl Jan 2, 2020
@anthonyterrell anthonyterrell changed the title WIP: Add support for additional user fields Add support for additional user fields Jan 2, 2020
Copy link
Contributor

bkuhl left a comment

This looks great! Could you also update https://github.com/helpscout/helpscout-api-php/blob/master/tests/Payloads/UserPayloads.php#L63-L82 to reflect the added fields as well?

src/Users/User.php Outdated Show resolved Hide resolved
@bkuhl
bkuhl approved these changes Jan 3, 2020
@bkuhl bkuhl merged commit 2deae4f into master Jan 3, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bkuhl bkuhl deleted the add-support-for-additional-user-fields branch Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.