Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHPCS Updates #264

Merged
merged 6 commits into from
Jan 26, 2021
Merged

PHPCS Updates #264

merged 6 commits into from
Jan 26, 2021

Conversation

bkuhl
Copy link
Contributor

@bkuhl bkuhl commented Jan 25, 2021

Updating some object property ordering to keep our coding standards consistent

@bkuhl bkuhl mentioned this pull request Jan 25, 2021
Merged
@bkuhl bkuhl requested a review from miguelrs January 25, 2021 20:49
@bkuhl
Copy link
Contributor Author

bkuhl commented Jan 25, 2021

Also enabled coverage for the CI build so it properly generates code coverage as expected

@bkuhl bkuhl merged commit 43585b2 into master Jan 26, 2021
@bkuhl bkuhl deleted the phpcs branch January 26, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelrs miguelrs miguelrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkuhl @miguelrs