Page.Action: Add guard for IntersectionObserver (#628)

This update adds a guard for `IntersectionObserver`, which is used for the sticky feature in `Page.Action`. The issue would only occur JSDOM. Target browsers (Edge+) supports this feature
helpscout · May 16, 2019 · f62f9bc · f62f9bc
1 parent dbade79
commit f62f9bc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/components/Page/Page.Actions.tsx b/src/components/Page/Page.Actions.tsx
@@ -72,7 +72,6 @@ export class Actions extends React.PureComponent<
       zIndex,
       ...rest
     } = this.props
-    const { isStickyActive } = this.state
 
     const content = (
       <ActionsUI

diff --git a/src/components/Page/Page.StickyActions.tsx b/src/components/Page/Page.StickyActions.tsx
@@ -32,6 +32,9 @@ class StickyActions extends React.PureComponent<
   }
 
   observerStart() {
+    /* istanbul ignore next */
+    if (!IntersectionObserver) return
+
     const { offset } = this.props
     const observerOptions = {
       root: null,
@@ -46,6 +49,9 @@ class StickyActions extends React.PureComponent<
   }
 
   observerStop() {
+    /* istanbul ignore next */
+    if (!IntersectionObserver) return
+
     this.observer.unobserve(this.node)
     this.observer.disconnect()
   }