This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Page.Action: Add guard for IntersectionObserver #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update adds a guard for `IntersectionObserver`, which is used for the sticky feature in `Page.Action`. The issue would only occur JSDOM. Target browsers (Edge+) supports this feature
|
Deploy preview for hsds-react ready! Built with commit cbae7ef |
Pull Request Test Coverage Report for Build 2188
💛 - Coveralls |
ItsJonQ
commented
May 16, 2019
| @@ -72,7 +72,6 @@ export class Actions extends React.PureComponent< | |||
| zIndex, | |||
| ...rest | |||
| } = this.props | |||
| const { isStickyActive } = this.state | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Page.Action: Add guard for IntersectionObserver
This update adds a guard for
IntersectionObserver, which is used for thesticky feature in
Page.Action.The issue would only occur JSDOM. Target browsers (Edge+) supports this
feature