This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Improve Portal/Modal components #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Updates** * Provide Portal with the ability to renderTo a custom selector * Add Portal.Container component for custom Portal rendering * Add onBeforeOpen, onOpen, onBeforeClose, onClose callback hooks to Portal * Add react-router support to Link component * Add react-router support to Modal component **Other** * Add react-router-dom * Moved react deps to peerDependencies in package.json * Add tests! 100% coverage 💪 * Update README
added 2 commits
August 30, 2017 18:15
This was referenced Aug 30, 2017
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
Main updates
Other
Resolves:
#8
#10