New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Lockfiles (`Proto.lock`) #38

Merged

mara-schulke merged 42 commits into main from mara/lockfile

Sep 22, 2023

Contributor

mara-schulke commented Sep 10, 2023 •

edited

Loading

Introduces

A Proto.lock (see lockfile #3)

Breaks

Existing manifests without [package]
Existing manifests without [dependencies]

mara-schulke added 3 commits

September 10, 2023 16:50


          Rename package id to package name

7f46767


          Refactor manifest structure

b2dd929


          Start with the typesystem for lockfiles

mara-schulke added this to the Stabilzation milestone

mara-schulke self-assigned this

mara-schulke marked this pull request as draft

September 10, 2023 18:15

mara-schulke linked an issue

that may be closed by this pull request

Closed

This was referenced Sep 10, 2023

Closed

Make packages deterministic #51

Merged

asmello self-assigned this

asmello added 8 commits

September 18, 2023 16:03


          draft

7fe7252


          Merge branch 'main' into mara/lockfile

0eab8fd


          post merge fixes

68672b4


          misc fixes, revert to mandatory manifest sections

afd5405


          allowlist ISC licenses

8f0c932


          tentative fix for ring license detection

da6a506


          improve display of installed packages

1782e22


          improve validation of lockfile

d811696

asmello marked this pull request as ready for review

September 19, 2023 13:22


          Some cleanup

b6ecc36

mara-schulke force-pushed the mara/lockfile branch from a996d1c to b6ecc36 Compare

September 19, 2023 14:22

mara-schulke commented

View reviewed changes

src/lock.rs Outdated Show resolved Hide resolved

mara-schulke commented

View reviewed changes

src/lock.rs Show resolved Hide resolved

mara-schulke commented

View reviewed changes

src/manifest.rs Outdated Show resolved Hide resolved

mara-schulke commented

View reviewed changes

src/package.rs Show resolved Hide resolved

mara-schulke commented

View reviewed changes

src/package.rs Show resolved Hide resolved

mara-schulke commented

View reviewed changes

src/command.rs Show resolved Hide resolved

mara-schulke requested review from wngr and uschi2000

September 19, 2023 14:38


          make RawManifest private

00303e6

asmello added 3 commits

September 20, 2023 15:43


          add missing lockfile validation for registry

a80bc30


          fix validation of package name

d96a7d6


          track dependants in lock entries

e20d2a0

alexespencer previously approved these changes

View reviewed changes

Contributor

alexespencer left a comment •

edited

Loading

Nice! Edit: this was meant to be against a single line, trying to delete...

alexespencer dismissed their stale review

September 20, 2023 15:40

Submitted in error

jonhoo reviewed

View reviewed changes

jonhoo left a comment

Ran a bit short on time, but manage to get through most of this — exciting to see this moving forward!

Cargo.toml Outdated Show resolved Hide resolved

docs/src/faq.md Outdated Show resolved Hide resolved

src/manifest.rs Outdated Show resolved Hide resolved

src/command.rs Show resolved Hide resolved

src/command.rs Outdated Show resolved Hide resolved

src/lock.rs Outdated Show resolved Hide resolved

src/lock.rs Outdated Show resolved Hide resolved

src/lock.rs Outdated Show resolved Hide resolved

src/lock.rs Show resolved Hide resolved

src/lock.rs Show resolved Hide resolved

mara-schulke commented

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

asmello and others added 16 commits

September 21, 2023 18:03


          lowercase word

9ad21a5

Co-authored-by: Mara Schulke <mara.schulke@helsing.ai>


          pin hex dependency version and upgrade others

4490dec


          unite imports in command.rs file


          feedback changes on lock.rs


          rename r#type field to kind

6861f0e


          move/rename initial version constant

49f194b


          change String argument to &str in add


          remove instead of retain

38a7dd6


          String to AsRef<Path> in package cmd


          derive PartialEq, Eq for Digest

ef4af4f


          tweak init code

45b5946


          make Digest Ord impl more robust

ae59a42


          Merge branch 'main' into mara/lockfile

62e96f1


          improve naming of install subfunction

835af1a


          make dependencies section optional

a064cee


          use serde default

11b1076

Collaborator

asmello commented Sep 22, 2023

Ok I believe I've accounted for all feedback now!

mara-schulke commented

View reviewed changes

src/manifest.rs Show resolved Hide resolved

mara-schulke commented

View reviewed changes

Contributor Author

mara-schulke left a comment

Is the dependency section now optional?

Collaborator

asmello commented Sep 22, 2023

Is the dependency section now optional?

Yes it is!

mara-schulke merged commit 8d0f5ae into main

5 checks passed

mara-schulke deleted the mara/lockfile branch

September 22, 2023 12:08

xfbs mentioned this pull request

Clean up imports. #106

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

j-baker j-baker left review comments

jonhoo jonhoo left review comments

asmello asmello left review comments

alexespencer alexespencer left review comments

wngr Awaiting requested review from wngr

uschi2000 Awaiting requested review from uschi2000

Labels

None yet