Add fmaddsub/ fmsubadd / faddsub/ fsubadd #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some fancier llvm instructions that might target complex arithmetic (if using interleaved format) but in general our instruction set dependent.
For example, on my x86_64-linux-gnu which has the available instruction
compared to my ARM computer which doesn't have this specific instrinsic.
So the LLVM code is doing an ok job in this case. Unfortunately, the
fmaddsub
could be better..LLVM should be able to generate a single
_m128d _mm_fmaddsub_pd
instruction there.... that seems like an LLVM issue or just on my computer. I don't have a different CPU to test it out.There is an open in issue in SIMD.jl for this that I'll comment on.