Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't follow example code if I install via Pod #1

Closed
huydangquoc opened this issue Oct 2, 2018 · 3 comments
Closed

Can't follow example code if I install via Pod #1

huydangquoc opened this issue Oct 2, 2018 · 3 comments
Assignees
Labels

Comments

@huydangquoc
Copy link

As I follow Installation section

If I install manually and follow example project, It works well.

If I install via cocoa pod and follow the same example project, I get this error
internal access level

When I change access level of reload and close functions to public, it works well.
change to public

@hemangshah
Please help consider change these methods accordingly. Or if you're OK with these changes, I will create PR for them.

Thanks,
Huy

@hemangshah hemangshah self-assigned this Oct 2, 2018
@hemangshah hemangshah added the bug label Oct 2, 2018
@hemangshah
Copy link
Owner

@huydangquoc , thank you! I am surprised there are 78 downloads made via CocoaPods and you only complaint about it 👍 I'll release a new version soon. Will keep you posted. I would love to have your PR but I need to make some more changes (refactoring) of code to have best swift practices so this time I'll handle this. But feel free to give your feedback on the same.

@hemangshah
Copy link
Owner

Hi again @huydangquoc ,

🚀 HHFloatingView (1.4.0) successfully published
📅 October 2nd, 18:56
🌎 https://cocoapods.org/pods/HHFloatingView

Please feel free to use the latest pod and give your feedback.

@huydangquoc
Copy link
Author

Dear @hemangshah, thank you for your quick response, highly appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants